refactor: simplify switch and improve locking in ClusterRendererMultipleItems #1557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pleItems - Replaced a traditional switch statement with an enhanced switch expression in `setAnimationType`. - Added a `setAnimationInterpolator` method to allow custom interpolators. - Ensured `lock.unlock()` is always called in `finally` blocks within `MarkerModifier` and `AnimationTask` for better resource management. - Added `@Override` annotation to `ViewModifier.run()`.
Code Coverage
|
kikoso
reviewed
Aug 6, 2025
| } | ||
|
|
||
| public void setAnimationInterpolator(TimeInterpolator interpolator) { |
There was a problem hiding this comment.
Being this a public method, worth considering adding a line of documentation to explain that it sets the Interpolator for the current animation.
|
Would it make sense to add some of this changes (namely, overriding the Besides that, this changes make sense. |
kikoso
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setAnimationType.setAnimationInterpolatormethod to allow custom interpolators.lock.unlock()is always called infinallyblocks withinMarkerModifierandAnimationTaskfor better resource management.@Overrideannotation toViewModifier.run().